Open Radar

 
Summary:
There are some situations where the conditions determining a a constant value are more complicated than can be represented in ternary operator, do not merit a separate function call, and would benefit from remaining non-optional constants instead of variables or optionals.

Steps to Reproduce:
func ordinalSuffix(num:Int) -> String {
    let abs_number = abs(num)
    let rem10 = abs_number % 10
    let rem100 = abs_number % 100
    
    if (rem100 == 11 ||
        rem100 == 12 ||
        rem100 == 13) { /** cannot use range object*/
        return "th"
    } else if rem10 == 1 {
        return "st"
    } else if rem10 == 2 {
        return "nd"
    } else if rem10 == 3 {
        return "rd"
    } else {
        return "th"
    }
}

Expected Results:
func ordinalSuffix(num:Int) -> String {
    let abs_number = abs(num)
    let rem10 = abs_number % 10
    let rem100 = abs_number % 100
    
    let suffixString = if (rem100 == 11 ||
        rem100 == 12 ||
        rem100 == 13) {
        "th"
    } else if rem10 == 1 {
        "st"
    } else if rem10 == 2 {
        "nd"
    } else if rem10 == 3 {
        "rd"
    } else {
        "th"
    }

    return suffixString
}

Actual Results:
only the first example works

Version:


Notes:


Configuration:


Attachments: